[webkit-reviews] review denied: [Bug 44508] [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL : [Attachment 65388] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 44508: [EFL] Add PlatformVideoWindowEfl.cpp for WebKit EFL
https://bugs.webkit.org/show_bug.cgi?id=44508

Attachment 65388: Patch
https://bugs.webkit.org/attachment.cgi?id=65388&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>

> +#include "Widget.h"
> +
>  #include <wtf/PassRefPtr.h>

Please remove this extra line. There is no need to separate the include styles.


>  #if PLATFORM(GTK)
>  #include <gtk/gtk.h>
> -typedef GtkWidget PlatformWindowType;
> +#endif
> +
> +#if !PLATFORM(EFL) || ENABLE(GLIB_SUPPORT)
> +#include <glib.h>
>  #endif

Is the only reason for these #ifdefs and #includes gulong? Having
GLib and/or GTK+ includes in a header files can increase the compilation
time unecessarily. If possible, please just use unsigned long instead of
gulong and remove all the #ifdefs and #includes. Thanks!
  
> diff --git a/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp
b/WebCore/platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp

Should this also be added to the CMake build scripts?