[webkit-reviews] review denied: [Bug 44360] Add Chromium API for FileWriter : [Attachment 65638] Fixed issues Kinuko found

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Eric U.
<ericu at chromium.org>'s request for review:
Bug 44360: Add Chromium API for FileWriter
https://bugs.webkit.org/show_bug.cgi?id=44360

Attachment 65638: Fixed issues Kinuko found
https://bugs.webkit.org/attachment.cgi?id=65638&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebFileWriterClient.h:48
 +	// Called if the write or truncate fails, or if it is cancelled before
didWrite or didTruncate is called.
what does the client call sequence look like if writing completes but cancel is
called before didWrite(bytes, true) is called?

the comment above for didFail says that didFail will be called if cancel is
called before didWrite or didTruncate is called.  but what if the system did
complete writing the file before that time?

i'm concerned that it is complicated for the client to know that if he receives
didWrite(bytes, true) that didFail may or may not follow.  he would need to
keep track of whether or not he called cancel.

WebKit/chromium/src/AsyncFileWriterChromium.cpp:43
 +  AsyncFileWriterChromium::AsyncFileWriterChromium(WebCore::FileWriterClient*
client)
nit: i recommend putting a 'using namespace WebCore' at the top so you can drop
the WebCore:: prefix in this .cpp file