[webkit-reviews] review requested: [Bug 44744] Fix Coverage build after the addition of ANGLE : [Attachment 65668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 20:36:31 PDT 2010


Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 44744: Fix Coverage build after the addition of ANGLE
https://bugs.webkit.org/show_bug.cgi?id=44744

Attachment 65668: Patch
https://bugs.webkit.org/attachment.cgi?id=65668&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
ANGLE is using libtool to build a static library and the version of
libtool on Leopard refuses to handle the -fprofile-arcs and -ftest-coverage
parameters. The easiest way to handle this is to not build ANGLE with
coverage information.

This is achieved by applying the XCode options for each project
separately and exclude ANGLE.

* Scripts/build-webkit: Remove -framework AppKit due link errors.
* Scripts/webkitdirs.pm: Do not apply the XCode options for ANGLE.
---
 3 files changed, 23 insertions(+), 5 deletions(-)


More information about the webkit-reviews mailing list