[webkit-reviews] review requested: [Bug 44729] Add support for GPU accelerated path rendering : [Attachment 65655] Cubic curve classification, texture coordinate assignment, local triangulation and math utilities

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 44729: Add support for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=44729

Attachment 65655: Cubic curve classification, texture coordinate assignment,
local triangulation and math utilities
https://bugs.webkit.org/attachment.cgi?id=65655&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
It seems to me that it will make it easier to understand the motivation for
some of this code to have all of it available for perusal in patch form, so I
am continuing to upload patches before review decisions are made on earlier
ones.

>From the ChangeLog:

This patch adds the classification of cubic curve segments into categories,
assignment of texture coordinates to the curves' control points for later
rendering on the GPU, the algorithm for triangulating an individual cubic curve
and walking its interior edges for assembly into a complete filled shape, and
several utility routines related to geometry and cubic curve processing, some
ported from Skia.

The reason for the style violations in the header guards is described in the
earlier patch. There is another violation around the use of the letter l as an
identifier, but the algorithm defines coordinates k, l, and m, so it seems best
to match the algorithm's terminology rather than the style guide in this case.