[webkit-reviews] review granted: [Bug 44728] Adopt more uses OwnPtr/OwnArray in WebKit2 : [Attachment 65636] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 17:48:24 PDT 2010


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 44728: Adopt more uses OwnPtr/OwnArray in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44728

Attachment 65636: Patch
https://bugs.webkit.org/attachment.cgi?id=65636&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    for (size_t i = 0; i < m_size; ++i)
> -	   m_entries[i]->ref();

You got rid of the ref() here. That is not right, is it?

Should this be an array of RefPtr<APIObject>?

r=me as long as you fix that ref thing


More information about the webkit-reviews mailing list