[webkit-reviews] review requested: [Bug 44729] Add support for GPU accelerated path rendering : [Attachment 65642] Core data structures: Arena, RedBlackTree and IntervalTree

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 44729: Add support for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=44729

Attachment 65642: Core data structures: Arena, RedBlackTree and IntervalTree
https://bugs.webkit.org/attachment.cgi?id=65642&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
>From the ChangeLog:

This initial patch adds two key data structures needed for the processing of
paths, and a specialized arena allocator which does not call the destructors of
allocated objects. It will be more obvious how these data structures are used
in later patches. We can consider making them more general and incorporating
them into WTF, but this will require very careful thought and possibly
significant redesign, and I would like to first land a working version of this
code.

The scoping of #include paths and the use of a sub-namespace is deliberate.
While this pattern is rarely used in the WebKit project, there are existing
examples (WTF), and I believe that it is a good one to enforce modularity. I
strongly desire to avoid collisions with other headers and class names in
WebCore, and want to be able to export a few selected classes from this
package.

The few style violations are the scoped #include guards and the use of streams
for debug-only printing code. The former are necessary to avoid header
collisions; the latter could be changed if desired.