[webkit-reviews] review granted: [Bug 44726] WebFrameProxies aren't destroyed until a page is destroyed : [Attachment 65633] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 15:52:51 PDT 2010


Sam Weinig <sam at webkit.org> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 44726: WebFrameProxies aren't destroyed until a page is destroyed
https://bugs.webkit.org/show_bug.cgi?id=44726

Attachment 65633: proposed patch
https://bugs.webkit.org/attachment.cgi?id=65633&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
Nice. I was kind of assuming we were going to use the detachFromParent
FrameLoaderClient functions, but I like this approach. Are we going to
need/want a way to signal that a Frame has changed Pages in the WebKit2 API?

r=me


More information about the webkit-reviews mailing list