[webkit-reviews] review denied: [Bug 44720] Remove unnecessary AlphaBlend in PasteboardWin : [Attachment 65623] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 15:01:53 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 44720: Remove unnecessary AlphaBlend in PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=44720

Attachment 65623: Patch
https://bugs.webkit.org/attachment.cgi?id=65623&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   Replacing AlphaBlend with BitBlt is save because testing showed that
alpha

Typo: save (should be "safe")

> +	   never survives copy-and-paste on Windows in any browser, and
StretchBlt 
> +	   was a overkill since the source and destination size are always
equal.

Typo: a overkill (should be "overkill")

Soooo close!


More information about the webkit-reviews mailing list