[webkit-reviews] review granted: [Bug 44693] [WINCE] Port SoftLinking to WinCE : [Attachment 65614] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 44693: [WINCE] Port SoftLinking to WinCE
https://bugs.webkit.org/show_bug.cgi?id=44693

Attachment 65614: Patch
https://bugs.webkit.org/attachment.cgi?id=65614&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   Add a platformdependent macro for GetProcAddress.

Typo: platformdependent

> +#if OS(WINCE)
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName)
GetProcAddressW(library##Library(), L###functionName)
> +#else
> +#define SOFT_LINK_GETPROCADDRESS(library, functionName)
GetProcAddress(library##Library(), #functionName)
> +#endif

Should we use GetProcAddressA on WinCE? GetProcAddress on NT is ANSI-only IIRC.


r+ since the code looks fine, but you should consider the above.