[webkit-reviews] review requested: [Bug 44133] Implement an XHR.responseBlob accessor : [Attachment 65607] xhr.responseBlob bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 13:16:23 PDT 2010


Michael Nordman <michaeln at google.com> has asked  for review:
Bug 44133: Implement an XHR.responseBlob accessor
https://bugs.webkit.org/show_bug.cgi?id=44133

Attachment 65607: xhr.responseBlob bindings
https://bugs.webkit.org/attachment.cgi?id=65607&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Ok... let's try this again this time with the new m_asBlob data member in the
initializer list and initted to false.

@@ -171,6 +172,9 @@ XMLHttpRequest::XMLHttpRequest(ScriptExe
     : ActiveDOMObject(context, this)
     , m_async(true)
     , m_includeCredentials(false)
+#if ENABLE(XHR_RESPONSE_BLOB)
+    , m_asBlob(false)
+#endif
     , m_state(UNSENT)
     , m_responseText("")
     , m_createdDocument(false)


And another small change to conditionally define the runtime enabled flag

+#if ENABLE(XHR_RESPONSE_BLOB)
+    static bool isXHRResponseBlobEnabled;
+#endif


More information about the webkit-reviews mailing list