[webkit-reviews] review granted: [Bug 44702] Make it possible for http tests to log resource requests : [Attachment 65599] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 44702: Make it possible for http tests to log resource requests
https://bugs.webkit.org/show_bug.cgi?id=44702

Attachment 65599: Patch
https://bugs.webkit.org/attachment.cgi?id=65599&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +main frame - didStartProvisionalLoadForFrame
> +main frame - didCommitLoadForFrame
> +main frame - didFinishDocumentLoadForFrame
> +main frame - didHandleOnloadEventsForFrame
> +main frame - didFinishLoadForFrame

It seems like this test needn't be in loading subdirectory - or we need a way
to avoid this noise output.

+    generateNoCacheHTTPHeader();
+    header("Last-Modified: " . gmdate("D, d M Y H:i:s T",
filemtime($resourceLogFile)));

Why bother with Last-Modified if the response not cacheable?

r=me.