[webkit-reviews] review denied: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63943] Part 6: FullScreen-WebKit

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied  review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099

Attachment 63943: Part 6: FullScreen-WebKit
https://bugs.webkit.org/attachment.cgi?id=63943&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>

> Index: WebKit/mac/WebView/WebPreferences.h
> ===================================================================
> --- WebKit/mac/WebView/WebPreferences.h	(revision 65005)
> +++ WebKit/mac/WebView/WebPreferences.h	(working copy)
> @@ -437,6 +437,28 @@ caching behavior.
>  */
>  - (WebCacheModel)cacheModel;
>  
> +#if ENABLE(FULLSCREEN_API)
> +/*!
> + @method setFullScreenEnabled:
> + 
> + @abstract
> + 
> + @param 
> + 
> + @discussion
> + */
> +- (void)setFullScreenEnabled:(BOOL)flag;
> +
> +/*!
> + @method fullScreenEnabled:
> + 
> + @abstract
> + 
> + @result
> + */
> +- (BOOL)fullScreenEnabled;
> +#endif
> +
> 
Dan reminds me that #if ENABLE() can't be in a public header.