[webkit-reviews] review granted: [Bug 44642] js-test-post.js is not robust for asynchronous tests : [Attachment 65493] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 44642: js-test-post.js is not robust for asynchronous tests
https://bugs.webkit.org/show_bug.cgi?id=44642

Attachment 65493: Patch
https://bugs.webkit.org/attachment.cgi?id=65493&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
The change seems fine.

> +isAllScriptParsed = true;

I think that adding this new window property might affect tests that dump
everything on the window object. Did you run all the scripts to test?

I would name this variable postTestScriptWasParsed or wasPostTestScriptParsed.

> +    if (window.isFinishJSTestCalled)

I would name this variable finishJSTestWasCalled or wasFinishJSTestCalled.