[webkit-reviews] review granted: [Bug 43099] Add JavaScript API to allow a page to go fullscreen : [Attachment 63943] Part 6: FullScreen-WebKit
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 26 11:23:54 PDT 2010
Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 43099: Add JavaScript API to allow a page to go fullscreen
https://bugs.webkit.org/show_bug.cgi?id=43099
Attachment 63943: Part 6: FullScreen-WebKit
https://bugs.webkit.org/attachment.cgi?id=63943&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> // These are private both because callers should be using the cover methods
and because the
> Index: WebKit/mac/WebView/WebPreferences.h
> ===================================================================
> --- WebKit/mac/WebView/WebPreferences.h (revision 65005)
> +++ WebKit/mac/WebView/WebPreferences.h (working copy)
> @@ -437,6 +437,28 @@ caching behavior.
> */
> - (WebCacheModel)cacheModel;
>
> +#if ENABLE(FULLSCREEN_API)
> +/*!
> + @method setFullScreenEnabled:
> +
> + @abstract
> +
> + @param
> +
> + @discussion
> + */
> +- (void)setFullScreenEnabled:(BOOL)flag;
> +
> +/*!
> + @method fullScreenEnabled:
> +
> + @abstract
> +
> + @result
> + */
> +- (BOOL)fullScreenEnabled;
> +#endif
> +
> @end
>
You should fill in @abstract and @result for both of these.
r=me with this change.
More information about the webkit-reviews
mailing list