[webkit-reviews] review granted: [Bug 26396] Percentage top value on position:relative descendant not resolved correctly if containing block height is not specified explicitly : [Attachment 65525] Patch w/ WinIE quirk handling

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 11:18:22 PDT 2010


Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 26396: Percentage top value on position:relative descendant not resolved
correctly if containing block height is not specified explicitly
https://bugs.webkit.org/show_bug.cgi?id=26396

Attachment 65525: Patch w/ WinIE quirk handling
https://bugs.webkit.org/attachment.cgi?id=65525&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    RenderBlock* theContainingBlock = containingBlock();

We normally don't use "the" in this way. Instead we do this:

    RenderBlock* containingBlock = this->containingBlock();

> +<div style="position: relative; top: 50%;">This text with top percent
relative and containing block auto should apear inside the red border</div>

The word appear is misspelled.


More information about the webkit-reviews mailing list