[webkit-reviews] review requested: [Bug 36303] Inserting CSS rules one at a time via js causes slow synchronous style recalculation : [Attachment 65578] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 10:41:53 PDT 2010


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 36303: Inserting CSS rules one at a time via js causes slow synchronous
style recalculation
https://bugs.webkit.org/show_bug.cgi?id=36303

Attachment 65578: Patch
https://bugs.webkit.org/attachment.cgi?id=65578&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This patch fixes the bug.  One layout test changes results to be incorrect, but
it's an artifact of a later style recalc happening after the HTML5 parser
altered the document to be in quirks mode without doing a style recalc of its
own.  The timer-based one then fixes the document up.  After I land this patch,
I'm going to do a big doctype/quirks mode cleanup now that I have discovered
this issue.


More information about the webkit-reviews mailing list