[webkit-reviews] review denied: [Bug 44679] Web Inspector: provide more information to front-end when breaking on DOM event : [Attachment 65564] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 26 09:20:53 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44679: Web Inspector: provide more information to front-end when breaking
on DOM event
https://bugs.webkit.org/show_bug.cgi?id=44679

Attachment 65564: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=65564&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Please run Dromaeo tests before and after the change to prove that it does not
regress performance.

WebCore/dom/ContainerNode.cpp:137
 +  #if ENABLE(INSPECTOR)
These deserve inline function definitions. I'd do it on inspector controller in
order to hide the complexity too:
InspectorController::willInsertDOMNode(this, child);
InspectorController::didInsertDOMNode(this, child);
InspectorController::willRemoveDOMNode(this, child);


More information about the webkit-reviews mailing list