[webkit-reviews] review granted: [Bug 44518] Web Inspector: add audits support to extension API : [Attachment 65557] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted  review:
Bug 44518: Web Inspector: add audits support to extension API
https://bugs.webkit.org/show_bug.cgi?id=44518

Attachment 65557: patch
https://bugs.webkit.org/attachment.cgi?id=65557&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
LayoutTests/inspector/extensions-audits.html:15
 +	    results.addResult("Passed rule", "this rule always passes ok",
webInspector.audits.severity.info);
webInspector.audits.severity.info - too many letters! result.Severity.Info ?

WebCore/inspector/front-end/AuditsPanel.js:59
 +	    this._launcherView.addCategory(this.categoriesById[id]);
indent.

WebCore/inspector/front-end/AuditsPanel.js:163
 +		category.run(resources, ruleResultReadyCallback.bind(null,
result));
bind(null) looks strange.

LayoutTests/inspector/extensions-audits-expected.txt:13
 +  category.onAuditStarted fired, results dump follows:
It'd be great to dump APIs to a separate expectations file for better
readability.