[webkit-reviews] review granted: [Bug 44230] REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector : [Attachment 65560] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 44230: REGRESSION: Crash occurs at objc_msgSend when closing a window that
is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230

Attachment 65560: Patch
https://bugs.webkit.org/attachment.cgi?id=65560&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
r+ with nits.

WebCore/inspector/InspectorFrontendHost.cpp:173
 +	    disconnectClient(); // Disconnect from client.
Why does disconnecting from backend cut the link to the client? I think it
should be cut by the client itself.

WebCore/inspector/front-end/inspector.js:719
 +	    return;
Can this happen?

WebKit/chromium/src/InspectorFrontendClientImpl.cpp:110
 +	m_client->closeWindow();
We might want to clear the link to client from here instead.

WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp:277
 +  void InspectorFrontendClient::destroyInspectorWindow(bool
notifyInspectorController)
That is fine for now, but we should remove the link from inspector frontend
client to the inspected page. It should go through a inspector / inspectable
mapping class as we have it in chromium. Maybe we can implement a common one in
WebCore.

WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:1
 +  /* {
Remove this change.