[webkit-reviews] review granted: [Bug 40730] allow ports with windowed plugins to support windowless plugin tests : [Attachment 59027] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Robert Hogan
<robert at webkit.org>'s request for review:
Bug 40730: allow ports with windowed plugins to support windowless plugin tests
https://bugs.webkit.org/show_bug.cgi?id=40730

Attachment 59027: Patch
https://bugs.webkit.org/attachment.cgi?id=59027&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
WebCore/plugins/qt/PluginViewQt.cpp:297
 +	if (!xEvent->xkey.keycode) {
Perhaps this should be guarded with a drt run-time guard?

WebCore/plugins/qt/PluginViewQt.cpp:@
 +  void PluginView::setFocus(bool focused)
The changes in this function worry me a bit. Should sending the X focus event
perhaps be guarded with !m_isWindowed or simply be moved into the else() block,
in order to avoid that the event receives the X focus event twice, once through
X itself (xembed) and once through the direct dispatchNPEvent() call.

The rest of the patch looks excellent to me! I'm sorry that it's been rotting
away :(

I'm going to say r+ with the condition that the X focus event code should be
moved so that it's not sent twice in case of windowed plugins.