[webkit-reviews] review canceled: [Bug 41832] [DRT] DRT should be able to dump document markers. : [Attachment 65208] A possible fix 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 23:16:04 PDT 2010


Hironori Bono <hbono at chromium.org> has canceled Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 41832: [DRT] DRT should be able to dump document markers.
https://bugs.webkit.org/show_bug.cgi?id=41832

Attachment 65208: A possible fix 3
https://bugs.webkit.org/attachment.cgi?id=65208&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
(In reply to comment #8)
> I'm sorry that I was wrong.
> What I meant is WebFramePrivate.h. WebXxxPrivate.h looks the location where
> we put test-specific (or other Apple specific) APIs. 
> There are WebViewPrivate.h, WebPrefrencesPrivate.h, etc.
> WebFrame.h is a part of WebKit public API and will be shipped with WebKit
framework.
> So it would be safe to avoid something new there.

It makes sense to move this function to WebFramePrivate.h. I have updated my
change.
 
> About a test, how about to adopt script-tests style?
> This test is for DumpRenderTree itself and doesn't need to run on the
browser.
> So we can use script-tests safely and it would make the test more concise.

These tests depends on "LayoutTests/editing/editing.js" to send editor
commands. To move my tests to "LayoutTests/dom/script-tests", I need to copy
some functions in the "editing.js" to my tests. I'm wondering if it is good to
copy such editor functions to script-tests.

Regards,


More information about the webkit-reviews mailing list