[webkit-reviews] review granted: [Bug 42292] Add NetworkingContext to avoid layer violations : [Attachment 64998] Provide NetworkingContext access
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 25 18:07:51 PDT 2010
Darin Adler <darin at apple.com> has granted Diego Gonzalez
<diegohcg at webkit.org>'s request for review:
Bug 42292: Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292
Attachment 64998: Provide NetworkingContext access
https://bugs.webkit.org/attachment.cgi?id=64998&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> +NetworkingContext* FrameLoader::networkingContext()
> +{
> + return m_networkingContext.get();
> +}
Seems to me this should be inline in the header. No reason to pay function call
overhead just to fetch the value of a field.
It's a little strange to add all of this as dead code. Not quite the same thing
as adding only the header files, but I guess still a good idea.
More information about the webkit-reviews
mailing list