[webkit-reviews] review granted: [Bug 36303] Inserting CSS rules one at a time via js causes slow synchronous style recalculation : [Attachment 65505] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 36303: Inserting CSS rules one at a time via js causes slow synchronous
style recalculation
https://bugs.webkit.org/show_bug.cgi?id=36303

Attachment 65505: Patch
https://bugs.webkit.org/attachment.cgi?id=65505&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/rendering/RenderBlock.cpp
> ===================================================================
> --- WebCore/rendering/RenderBlock.cpp (revision 66057)
> +++ WebCore/rendering/RenderBlock.cpp (working copy)
> @@ -4132,8 +4132,7 @@ void RenderBlock::setDesiredColumnCountA
>      bool destroyColumns = !firstChild()
>			     || (count == 1 && style()->hasAutoColumnWidth())
>			     || firstChild()->isAnonymousColumnsBlock()
> -			     || firstChild()->isAnonymousColumnSpanBlock()
> -			     ||
document()->settings()->paginateDuringLayoutEnabled();
> +			     || firstChild()->isAnonymousColumnSpanBlock();

Unrelated change here.

I like it! r=me