[webkit-reviews] review granted: [Bug 44648] new-run-webkit-tests: add rebaselining tests for test_expectations : [Attachment 65500] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 16:52:40 PDT 2010


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 44648: new-run-webkit-tests: add rebaselining tests for test_expectations
https://bugs.webkit.org/show_bug.cgi?id=44648

Attachment 65500: Patch
https://bugs.webkit.org/attachment.cgi?id=65500&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
> +    def test_remove_expand(self):
> +	   # This test is somewhat counterintuitive - lines with no platform
> +	   # specified get expanded to every platform.
> +	   self.assertRemove('',
> +	       'BUGX REBASELINE : failures/expected/text.html = TEXT\n',
> +	       'BUGX REBASELINE MAC WIN : failures/expected/text.html =
TEXT\n')

This looks wrong. Mind adding a FIXME and filing a bug CCed to victorw? It's
not a big deal, but it does bloat test_expectations.


More information about the webkit-reviews mailing list