[webkit-reviews] review granted: [Bug 44629] Crash when switching to tiled layer when parent is also a tiled layer : [Attachment 65479] Patch with test case

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 44629: Crash when switching to tiled layer when parent is also a tiled
layer
https://bugs.webkit.org/show_bug.cgi?id=44629

Attachment 65479: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=65479&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
WebCore/platform/graphics/win/WKCACFLayer.h:65
 +	    ASSERT(CACFLayerGetUserData(layer) !=
reinterpret_cast<void*>(0xDeadBeef));
I think 0xDeadBeef should be all lower- or uppercase. 

WebCore/platform/graphics/win/WKCACFLayer.cpp:185
 +	CACFLayerSetUserData(layer(), reinterpret_cast<void*>(0xDeadBeef));
Only do this in debug builds.

Seems like the underlying cause is that we mess with sublayerCount() for tiled
layers. It would be nice to find a way to avoid that source of confusion.