[webkit-reviews] review granted: [Bug 44617] Web Inspector: explicit callId argument can be removed from the functions signatures declared in Inspector.idl : [Attachment 65462] [patch] initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 44617: Web Inspector: explicit callId argument can be removed from the
functions signatures declared in Inspector.idl
https://bugs.webkit.org/show_bug.cgi?id=44617

Attachment 65462: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=65462&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/CodeGeneratorInspector.pm:357
 +	push(@function, "	 responseMessage->setString(\"type\",
\"response\");");
Why do we specify type for something that has seq?

WebCore/inspector/CodeGeneratorInspector.pm: 
 +	    reportProtocolError(callId, "dispatch", "Error: Invalid message
format. The type of 'command' property should be string.");
I think this is time to write a test that would issue valid and invalid
requests against InspectorBackend and test the response.

WebCore/inspector/front-end/CSSStyleModel.js:94
 +	    InspectorBackend.setStyleText(styleId, cssText);
Is this case handled properly? A test would be great.