[webkit-reviews] review granted: [Bug 44628] canvas/philip/tests/2d.imageData.get.source.outside.html crashes test_shell in Chromium Linux debug : [Attachment 65452] Patch

[bugzilla-daemon at webkit.org]

Adam Langley <agl at chromium.org> has granted Dominic Cooney
<dominicc at google.com>'s request for review:
Bug 44628: canvas/philip/tests/2d.imageData.get.source.outside.html crashes
test_shell in Chromium Linux debug
https://bugs.webkit.org/show_bug.cgi?id=44628

Attachment 65452: Patch
https://bugs.webkit.org/attachment.cgi?id=65452&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
LGTM once the point below has been addressed. Note: I am not a WebKit Reviewer.
You need a real review from someone else before landing this patch.

> +	   In Chromium Skia getImageData don't retrieve the pointer into the
> +	   canvas bitmap when there are no columns to copy, because this
> +	   asserts when the source is outside the canvas bounds.

This sentence doesn't make sense.