[webkit-reviews] review requested: [Bug 32356] Implement smooth scrolling for multiple platforms : [Attachment 65459] patch v4.0

[bugzilla-daemon at webkit.org]

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 32356: Implement smooth scrolling for multiple platforms
https://bugs.webkit.org/show_bug.cgi?id=32356

Attachment 65459: patch v4.0
https://bugs.webkit.org/attachment.cgi?id=65459&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This patch implements some of the requests from comment 31.  Specifically, all
the changes to the signatures of create() (formerly possiblyCreateWithClient())
and scroll() (formerly possiblyAnimateScroll()) have been made.  One of the
requested changes, the addition of a ScrollbarClient::scrollSize() function,
seems kind of like unnecessary extra plumbing to me at this stage, given that
the old method with the scroll() caller providing a |maxPos| was easy to do
since that function only has one caller.  However, maybe it is a step toward a
better scrolling implementation.

Additionally, this makes all clients have a ScrollAnimator, which by default
does no animation.  This makes the scrolling model slightly more consistent and
thus less confusing.

I did not make major changes to ScrollView, such as trying to re-plumb
scrolling to not go through the scrollbars.  If we want to do that, I think we
need to redesign the entire flow for scrolling as a separate patch, rather than
do it in this.	I don't think that should gate this landing.