[webkit-reviews] review granted: [Bug 44594] [Qt] Add Visibility notification NPAPI for plugins : [Attachment 65453] Set clipRect correctly on X11

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 11:52:17 PDT 2010


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 44594: [Qt] Add Visibility notification NPAPI for plugins
https://bugs.webkit.org/show_bug.cgi?id=44594

Attachment 65453: Set clipRect correctly on X11
https://bugs.webkit.org/attachment.cgi?id=65453&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebCore/plugins/qt/PluginViewQt.cpp:588
 +	    // position and clipRect is relative to the Drawable
comments start with capital and ends with . Why is Drawable with a capital d?

The comments could be a bit more explanatory.


More information about the webkit-reviews mailing list