[webkit-reviews] review requested: [Bug 41165] FrameLoader cleanup : Remove m_URL member : [Attachment 65432] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 10:17:48 PDT 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 41165: FrameLoader cleanup : Remove m_URL member
https://bugs.webkit.org/show_bug.cgi?id=41165

Attachment 65432: patch
https://bugs.webkit.org/attachment.cgi?id=65432&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This change is large, but all mechanical except for FrameLoader and
Document::Document().

There are a couple of places in FrameLoader where we're logging the url, but
the document might be detached, so there are some null checks that need to
happen that weren't necessary previously.  Also, ordering of setting variables
needed to change in a couple of places.

The changes in Document's constructor are tweaking the handling of about:blank.
 I went for full backwards compatibility as defined by the existing layout
tests.


More information about the webkit-reviews mailing list