[webkit-reviews] review granted: [Bug 44607] Web Inspector: lazily request frontend settings instead of pushing them on connect : [Attachment 65410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 25 06:58:40 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 44607: Web Inspector: lazily request frontend settings instead of pushing
them on connect
https://bugs.webkit.org/show_bug.cgi?id=44607

Attachment 65410: Patch
https://bugs.webkit.org/attachment.cgi?id=65410&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/ProfilesPanel.js:204
 +	    this._requestedProfiles = false;
this._profilesWereRequested;
WebCore/inspector/Inspector.idl:102
 +	    [handler=Controller] void populateScriptObjects();
Please comment that it should be further split into the parts.


More information about the webkit-reviews mailing list