[webkit-reviews] review granted: [Bug 40794] When properties are missing from animation keyframes, interpolate between those keyframes that specify them : [Attachment 65207] Patch for some initial cleanup

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 40794: When properties are missing from animation keyframes, interpolate
between those keyframes that specify them
https://bugs.webkit.org/show_bug.cgi?id=40794

Attachment 65207: Patch for some initial cleanup
https://bugs.webkit.org/attachment.cgi?id=65207&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>      double offset = 0;
> -    Vector<KeyframeValue>::const_iterator endKeyframes =
m_keyframes.endKeyframes();
> -    for (Vector<KeyframeValue>::const_iterator it =
m_keyframes.beginKeyframes(); it != endKeyframes; ++it) {
> -	   if (t < it->key()) {
> +    size_t numKeyframes = m_keyframes.size();
> +    for (size_t i = 0; i < numKeyframes; ++i) {
> +	   const KeyframeValue& currKeyframe = m_keyframes[i];

I don't think there is a really compelling reason to continue using curr rather
than current here.

Otherwise, r=me.