[webkit-reviews] review denied: [Bug 44531] Web Inspector: Store heap snapshots in InspectorProfilerAgent : [Attachment 65286] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 44531: Web Inspector: Store heap snapshots in InspectorProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=44531

Attachment 65286: Patch
https://bugs.webkit.org/attachment.cgi?id=65286&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
LayoutTests/platform/chromium-win/http/tests/loading/307-after-303-after-post-e
xpected.txt:127
 +  inspector/ScriptView.js - didFailLoadingWithError: <NSError domain
NSURLErrorDomain, code -6, failing URL
"file:///C:/b/slave/webkit-rel/build/src/webkit/Release/resources/inspector/Scr
iptView.js">
I'd suggest to fix these poor expectations. Test is anyways disabled...

WebCore/inspector/front-end/ProfilesPanel.js:390
 +		if (this._profiles[i].typeId == typeId)
===

WebCore/inspector/front-end/ProfilesPanel.js:399
 +		if (this._profiles[i].typeId == profile.typeId
ditto

WebCore/inspector/front-end/ProfilesPanel.js:400
 +		    && this._profiles[i].uid == profile.uid) {
ditto

WebKit/chromium/src/js/HeapProfilerPanel.js:35
 +  WebInspector.HeapSnapshotView = function(parent, profile)
Why is this not in WebCore now? r- for this.

WebKit/chromium/src/js/HeapProfilerPanel.js:425
 +		     lastComparator = self.snapshotDataGridList.lastComparator;

bad indent.

WebKit/chromium/src/js/HeapProfilerPanel.js:460
 +		if (title.indexOf(UserInitiatedProfileName) === 0)
if (!title ...)

WebKit/chromium/src/js/DevTools.js:37
 +  devtools.ToolsAgent = function()
Please remove ToolsAgent as a whole since it is no longer used. Once you remove
it, please remove override of WebInspector.loaded that was used for the agent.
Just put Preferences overrides in the anonymous inline function there.

WebKit/chromium/src/js/DevTools.js:82
 +	var oldShow = WebInspector.ProfilesPanel.prototype.show;
This code should also be removed as a whole - no need to intercept profiles
panel showing anymore.