[webkit-reviews] review granted: [Bug 44434] [chromium] Add chromium-side of AsyncFileSystem implementation : [Attachment 65209] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 21:48:48 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 44434: [chromium] Add chromium-side of AsyncFileSystem implementation
https://bugs.webkit.org/show_bug.cgi?id=44434

Attachment 65209: Patch
https://bugs.webkit.org/attachment.cgi?id=65209&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/src/LocalFileSystemChromium.cpp:47
 +  using WebKit::WebFileSystemCallbacksImpl;
nit: since you are in WebKit, I would just put a "using namespace WebKit" here,
and
then drop the WebKit:: prefixes down below.


otherwise, R=me


More information about the webkit-reviews mailing list