[webkit-reviews] review granted: [Bug 44554] Delete LegacyHTMLTreeBuilder : [Attachment 65329] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 24 14:59:58 PDT 2010
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 44554: Delete LegacyHTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=44554
Attachment 65329: Patch
https://bugs.webkit.org/attachment.cgi?id=65329&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/WebCore.xcodeproj/project.pbxproj:
+ 512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h in Headers */ =
{isa = PBXBuildFile; fileRef = 512DD8EB0D91E6AF000F89EE /* LegacyWebArchive.h
*/; settings = {ATTRIBUTES = (Private, ); }; };
Looks unintentional.
WebCore/WebCore.xcodeproj/project.pbxproj:
+ 512DD8F50D91E6AF000F89EE /* LegacyWebArchive.h
in Headers */,
Looks unintentional.
WebCore/dom/Document.cpp:1925
+ #ifdef BUILDING_ON_LEOPARD
These need a FIXME before them, since the new treebuilder does not support
these hacks and (currently) we have no plan to.
WebCore/html/HTMLTreeBuilder.cpp:52
+ #include <wtf/dtoa.h>
You should mark this with a FIXME, no?
Otherwise looks fine.
More information about the webkit-reviews
mailing list