[webkit-reviews] review granted: [Bug 44486] Suffix for CSS alphabetic list style types should fallback to decimal for ordinals outside of their representable range : [Attachment 65212] Patch with test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 44486: Suffix for CSS alphabetic list style types should fallback to
decimal for ordinals outside of their representable range
https://bugs.webkit.org/show_bug.cgi?id=44486

Attachment 65212: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=65212&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    EListStyleType effectiveType = type;

I'd prefer if we just used return statements rather than a local variable that
we alter and then fall through to a shared return statement.

> +    // If the list-style-type, say hebrew, cannot represent |value| because
it's outside
> +    // its ordinal range then we fallback to some list style that can
represent |value|.

The word "fallback" is a noun or adjective. You want the verb phrase "fall
back".

I don't think the words "say hebrew" help much here.