[webkit-reviews] review granted: [Bug 32823] Various designmode="on"/"off" & execCommand("Undo") NULL pointer crashes : [Attachment 63394] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 32823: Various designmode="on"/"off" & execCommand("Undo") NULL pointer
crashes
https://bugs.webkit.org/show_bug.cgi?id=32823

Attachment 63394: Patch
https://bugs.webkit.org/attachment.cgi?id=63394&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!m_selectionToDelete.isRange() ||
m_selectionToDelete.start().isOrphan() || m_selectionToDelete.end().isOrphan())


I'd like to see a helper function for this so we don't have to repeat these
three checks every time. One version for the isNone and another for the isRange
variant I guess.