[webkit-reviews] review granted: [Bug 44538] Web Inspector: allow re-attaching front-end. : [Attachment 65296] [PATCH] Proposed change.

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 44538: Web Inspector: allow re-attaching front-end.
https://bugs.webkit.org/show_bug.cgi?id=44538

Attachment 65296: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=65296&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> diff WebCore/inspector/Inspector.idl
>  module core {
>      interface [Conditional=INSPECTOR] Inspector {
> +	   [notify] void frontendConnected();
>	   [notify] void addConsoleMessage(out Object messageObj);
>	   [notify] void addRecordToTimeline(out Object record);

These were alphabetical. Might be nice to follow suit with this one.


> diff WebCore/inspector/front-end/inspector.js
> +WebInspector.frontendConnected = function()
> +{
> +    // Reset front-end if it is connected to the backend second time.

Grammar: to the backend "a" second time

r=me with those fixes.