[webkit-reviews] review denied: [Bug 44527] [Qt] Implement WebKit::Module for qt : [Attachment 65281] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Balazs Kelemen
<kb at inf.u-szeged.hu>'s request for review:
Bug 44527: [Qt] Implement WebKit::Module for qt
https://bugs.webkit.org/show_bug.cgi?id=44527

Attachment 65281: proposed patch
https://bugs.webkit.org/attachment.cgi?id=65281&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
WebKit2/Platform/qt/ModuleQt.cpp:34
 +	// Try to remove the file suffix if the path contains it.
Try removing... 

You don't say why.

WebKit2/Platform/qt/ModuleQt.cpp:35
 +	QString path = static_cast<QString>(m_path);
What is m_path?

WebKit2/Platform/qt/ModuleQt.cpp:37
 +	if ((lastIndex = path.lastIndexOf(QString(".so"))) >= 0)
QLatin1String please

WebKit2/Platform/qt/ModuleQt.cpp:39
 +	else if ((lastIndex = path.lastIndexOf(QString(".dll"))) >= 0)
Same here

Apart from this it looks sane.