[webkit-reviews] review granted: [Bug 44424] Web Inspector: show DOM breakpoints in sidebar pane : [Attachment 65264] Proposed patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44424: Web Inspector: show DOM breakpoints in sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=44424

Attachment 65264: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=65264&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/inspector/front-end/BreakpointsSidebarPane.js:203
 +		return this._breakpoint.type < other._breakpoint.type ? -1 : 1;

You may replace this with
return this._breakpoint.type - other._breakpoint.type;

WebCore/inspector/front-end/DOMAgent.js:703
 +	    for (var type in nodeBreakpoints)
This will fail if nodeBreakpoints is undefined.