[webkit-reviews] review granted: [Bug 44448] Web Inspector: Trace to the style that contributes to the computed styles panel. : [Attachment 65261] [PATCH] Same with one more test expectation fixed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 24 06:27:07 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 44448: Web Inspector: Trace to the style that contributes to the computed
styles panel.
https://bugs.webkit.org/show_bug.cgi?id=44448
Attachment 65261: [PATCH] Same with one more test expectation fixed.
https://bugs.webkit.org/attachment.cgi?id=65261&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
LayoutTests/inspector/elements-tests.js:95
+ if (!treeItem.listItemElement.textContent.indexOf("width") ||
Please add comment.
LayoutTests/inspector/styles-computed-trace.html:75
+ Tests that disabling inherited style property does not break further style
inspection.
Please fix this.
LayoutTests/inspector/styles-disable-inherited.html:52
+ testController.notifyDone(testController.results);
You can omit the parameter.
WebCore/inspector/front-end/StylesSidebarPane.js:752
+ this._contributedProperties = {};
It doesn't seem used, please remove.
More information about the webkit-reviews
mailing list