[webkit-reviews] review requested: [Bug 44098] [EFL] Support to enable HTML5's Video based on gstreamer in WebKit-EFL : [Attachment 65257] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 44098: [EFL] Support to enable HTML5's Video based on gstreamer in
WebKit-EFL
https://bugs.webkit.org/show_bug.cgi?id=44098

Attachment 65257: Patch
https://bugs.webkit.org/attachment.cgi?id=65257&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Hello Rafael,

I modify this patch according to your point. I add ENABLE_GLIB_SUPPORT
condition for ENABLE_VIDEO as below,

383 +IF (ENABLE_VIDEO)
384 +  SET(ENABLE_GLIB_SUPPORT 1)
385 +  MESSAGE("Forcing Glib support")
386 +ENDIF()  
387 +

I tested this patch in http://www.html5demos.com/video. Video is played on
EWebLauncher.
However, video should be tested further. So, I cannot enable video as default
yet.

Unfortunately, recently, gtk guy added a patch for fullscreen video. The patch
influences on this patch. So,I need to solve the problem first. I make a bug
for the issue. (https://bugs.webkit.org/show_bug.cgi?id=44508). I think this
bug can be reviewed after finishing the new bug.

Thanks,
Gyuyoung Kim