[webkit-reviews] review canceled: [Bug 44509] Web Inspector: don't stop on DOM breakpoints when all breakpoints are deactivated : [Attachment 65251] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 24 03:47:09 PDT 2010


Yury Semikhatsky <yurys at chromium.org> has canceled Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 44509: Web Inspector: don't stop on DOM breakpoints when all breakpoints
are deactivated
https://bugs.webkit.org/show_bug.cgi?id=44509

Attachment 65251: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=65251&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
WebCore/bindings/v8/ScriptDebugServer.cpp:202
 +	m_breakpointsActivated = activated;
If we cannot make do without the flag in ScriptDebugServer, why not use only it
without one in V8? This way you wouldn't need to reset "breakpoints activated"
flag each time debugger agent is being created, this would also allow to
deactivate breakpoints for one page while leaving them active in other pages
being rendered by the same process.


More information about the webkit-reviews mailing list