[webkit-reviews] review requested: [Bug 44156] [Chromium] Remove rebaselined results for "fast/events/special-key-events-in-input-text.html" : [Attachment 65203] Proposed patch #2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 19:04:27 PDT 2010


Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 44156: [Chromium] Remove rebaselined results for
"fast/events/special-key-events-in-input-text.html"
https://bugs.webkit.org/show_bug.cgi?id=44156

Attachment 65203: Proposed patch #2
https://bugs.webkit.org/attachment.cgi?id=65203&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Thank you for your review and sorry for the test break caused by my change.

(In reply to comment #6)
> Oh, I thought the test_shell change was already committed.

Sorry for the lack of my explanation. When I talked in IRC, it is better to
remove these rebaselined results before landing my test_shell change (*1). I
will land it after this change is merged to Chrome.

(*1) http://codereview.chromium.org/3037053

(In reply to comment #7)
a> > Bono-san, please add a LayoutTests/platform/chromium/test_expectations.txt
change to this patch so that it contains "BUGWK44156 :
fast/events/special-key-events-in-input-text.html = TEXT".
> 
> BUG51036 : fast/events/special-key-events-in-input-text.html = TEXT
> is better.

Done. I forgot changing the test expectation. Thank you for noticing this.

Regards,

Hironori Bono


More information about the webkit-reviews mailing list