[webkit-reviews] review granted: [Bug 30457] Allow image requests started from unload handlers to outlive the page : [Attachment 65159] Addressing levin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 13:40:29 PDT 2010


David Levin <levin at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 30457: Allow image requests started from unload handlers to outlive the
page
https://bugs.webkit.org/show_bug.cgi?id=30457

Attachment 65159: Addressing levin's comments
https://bugs.webkit.org/attachment.cgi?id=65159&action=review

------- Additional Comments from David Levin <levin at chromium.org>
WebCore/loader/PingLoader.cpp:55
 +	PassOwnPtr<PingLoader> pingLoader(new PingLoader(frame, request));
When I mentioned using PassOwnPtr, I was thinking of a static create method,
but given the usage I suppose that would be overkill.

Since this is a local variable, use OwnPtr instead of PassOwnPtr.


More information about the webkit-reviews mailing list