[webkit-reviews] review granted: [Bug 44441] WebKit should nil out PDFView's delegate before releasing it : [Attachment 65141] Proposed patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Mike Thole <mthole at mikethole.com>'s request for
review:
Bug 44441: WebKit should nil out PDFView's delegate before releasing it
https://bugs.webkit.org/show_bug.cgi?id=44441

Attachment 65141: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=65141&action=review

------- Additional Comments from mitz at webkit.org
> Index: WebKit/mac/ChangeLog
> ===================================================================
> --- WebKit/mac/ChangeLog	(revision 65818)
> +++ WebKit/mac/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2010-08-23  Mike Thole  <mthole at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WebKit should nil out PDFView's delegate before releasing it

The change is good, but the description isn’t totally accurate. The problem is
that the WebPDFView is deallocated while it is still the delegate, not that the
PDFView is being released while having a non-nil delegate.