[webkit-reviews] review denied: [Bug 8519] WebCore doesn't fire window.onerror event when uncaught JavaScript exceptions are thrown : [Attachment 65106] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 23 05:29:30 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 8519: WebCore doesn't fire window.onerror event when uncaught JavaScript
exceptions are thrown
https://bugs.webkit.org/show_bug.cgi?id=8519
Attachment 65106: Patch
https://bugs.webkit.org/attachment.cgi?id=65106&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks sane to me. I am willing
WebCore/dom/Document.cpp:408
+ , m_reportingException(false)
This field is not used.
WebCore/dom/Document.h:1287
+ bool m_reportingException;
ditto
More information about the webkit-reviews
mailing list