[webkit-reviews] review granted: [Bug 44174] Web Inspector: extract profiler-related code and data from InspectorController into ProfilerAgent : [Attachment 65087] Comments addressed (forgot to mark the previous attachment as a patch.)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 01:49:07 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 44174: Web Inspector: extract profiler-related code and data from
InspectorController into ProfilerAgent
https://bugs.webkit.org/show_bug.cgi?id=44174

Attachment 65087: Comments addressed (forgot to mark the previous attachment as
a patch.)
https://bugs.webkit.org/attachment.cgi?id=65087&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/InspectorController.cpp:1470
 +  bool InspectorController::isRecordingUserInitiatedProfile() const
I'd rather get rid of the usage in the WebKit layer. WebKit is starting and
stopping it, why doesn't it track its own state? Also, I'd implement user
initiated profiling in the WebKit layer as a whole...

WebCore/inspector/InspectorProfilerAgent.cpp:62
 +	    : m_inspectorController(inspectorController)
Too many spaces.


More information about the webkit-reviews mailing list