[webkit-reviews] review granted: [Bug 44252] QWebView::selectionChanged() is never emitted. : [Attachment 64932] Proposed fix v3 (with ChangeLog w/o tabs)

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted  review:
Bug 44252: QWebView::selectionChanged() is never emitted.
https://bugs.webkit.org/show_bug.cgi?id=44252

Attachment 64932: Proposed fix v3 (with ChangeLog w/o tabs)
https://bugs.webkit.org/attachment.cgi?id=64932&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
(In reply to comment #11)
> The point of the original report was that QWebView::selectionChanged() _which
exists and is documented_ is never emitted. You cannot remove that signal due
to binary compatibility. You can, of course, obsolete it, but that's not my
call to make (and not my task to implement). Either way, the solution can't be
wontfix.

Ok, I was wrong. r=me on your 3rd patch.

> The second patch was a request from you guys. Take it or leave it, I don't
care either way :)

I do not think we need to have this signal to QGraphicsWebView. At least not
without a public discussion on the mainling list about.

So lets go for your first approach.