[webkit-reviews] review granted: [Bug 44392] [Qt] Gradient: Support inner radius larger than outer radius : [Attachment 65049] Proposed patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 22 00:15:09 PDT 2010


Ariya Hidayat <ariya.hidayat at gmail.com> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 44392: [Qt] Gradient: Support inner radius larger than outer radius
https://bugs.webkit.org/show_bug.cgi?id=44392

Attachment 65049: Proposed patch v2
https://bugs.webkit.org/attachment.cgi?id=65049&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
LGTM.re=me.

Minor issue:


WebCore/platform/graphics/qt/GradientQt.cpp:76
 +	    if (m_radial && !qFuzzyCompare(outerRadius, qreal(0))) {
Should be qFuzzyCompare(1 + outerRadius, qreal(1)).


More information about the webkit-reviews mailing list